Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package repository URLs #434

Merged
merged 2 commits into from
Jan 13, 2016
Merged

Update package repository URLs #434

merged 2 commits into from
Jan 13, 2016

Conversation

portertech
Copy link
Contributor

Updated the module to use the new Sensu package repository URLs, for example:

http://repositories.sensuapp.org/apt/

http://repositories.sensuapp.org/yum/

The new repositories contain the latest Sensu builds, >= 0.20.0 only. The repositories are part of the new Sensu Core build pipeline.

tumblr_mvrc0evts81swhepeo1_250_zps371b1695

@jlambert121
Copy link
Contributor

Just thinking about this, I'm wondering if we need to put a switch in based on the version of sensu requested unless you're planning on adding (at least) some of the older versions into your new repository.

@roobert
Copy link

roobert commented Dec 6, 2015

I made these changes independently and found that puppet runs fail due to the new repository key not being added. I had to add some version check hackery to add the key to clients that aren't running 0.21.0 in order to get the key added.

Would it not make more sense to add all the old packages to repositories.sensuapp.org and point repo.sensuapp.org to where the new packages are hosted?

@taik0
Copy link

taik0 commented Dec 9, 2015

How is this still not merged?

@jamtur01
Copy link
Contributor

jamtur01 commented Dec 9, 2015

@taik0 There appear to be open questions about the PR and backwards compability. Until those are resolved we're not going to merge the PR. Would welcome your input or addition to the PR! Thanks!

@jamtur01
Copy link
Contributor

jamtur01 commented Dec 9, 2015

Ping @portertech re old versions.

@taik0
Copy link

taik0 commented Dec 9, 2015

@jamtur01 Ops, I see, didn't know that @portertech was a Sensu contributor.
So we are waiting to see if Sensu add the old packages to the new repo?
If they didn't do it, should I create a PR like @jlambert121 said configuring the old or the new depending on the version?

@nhinds
Copy link
Contributor

nhinds commented Dec 20, 2015

It looks like this PR needs the apt key updated as well, the fingerprint doesn't match the key used by the APT repository. Same problem as Yelp/puppet-uchiwa#62

@shpoont
Copy link

shpoont commented Jan 3, 2016

Why not merge those repos as @roobert suggested? If I use current puppet module I get 4 months old version..

@portertech
Copy link
Contributor Author

Updated the key to match Yelp/puppet-uchiwa#62

@portertech
Copy link
Contributor Author

Ping @jlambert121

@poolski
Copy link
Contributor

poolski commented Jan 13, 2016

ping @jlambert121 ;)

jlambert121 added a commit that referenced this pull request Jan 13, 2016
Update package repository URLs
@jlambert121 jlambert121 merged commit 9bc7f4a into master Jan 13, 2016
@ghoneycutt ghoneycutt deleted the feature/new-repos branch July 26, 2017 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants